Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect cycles at end of compilation #307

Merged
merged 3 commits into from
Mar 3, 2017
Merged

detect cycles at end of compilation #307

merged 3 commits into from
Mar 3, 2017

Conversation

cmcarthur
Copy link
Member

Cuts 15-20% of compile time off the project I'm using to test.

Snakeviz before this change:

screen shot 2017-03-02 at 9 15 35 pm

After:

screen shot 2017-03-02 at 9 17 54 pm

@cmcarthur
Copy link
Member Author

cmcarthur commented Mar 3, 2017 •
edited
Loading

@drewbanin I think that this may have worked this way before graph refactor, either way this is far better.

@cmcarthur cmcarthur requested a review from drewbanin March 3, 2017 02:18
@drewbanin
Copy link
Contributor

this is great! makes total sense

@cmcarthur cmcarthur merged commit b6e4a82 into development Mar 3, 2017
@cmcarthur cmcarthur deleted the speedup/find-cycles-at-end branch March 3, 2017 04:26
yu-iskw pushed a commit to yu-iskw/dbt that referenced this pull request Aug 17, 2021
@clrcrl
Add zero_length_range_allowed arg to mutually_exclusive_ranges (dbt-l…
d04d6b3 
…abs#307)

Use boolean for zero range arg.

Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmcarthur @drewbanin